-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(sequence): remove endpoint comparison helpers #17125
Merged
scottn12
merged 5 commits into
microsoft:next
from
connorskees:feat/remove-endpoint-compare
Sep 20, 2023
Merged
chore(sequence): remove endpoint comparison helpers #17125
scottn12
merged 5 commits into
microsoft:next
from
connorskees:feat/remove-endpoint-compare
Sep 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redundant with methods on IInterval
connorskees
changed the title
remove endpoint comparison helpers
feat(sequence): remove endpoint comparison helpers
Aug 31, 2023
github-actions
bot
added
area: dds
Issues related to distributed data structures
area: dds: sharedstring
base: next
PRs targeted against next branch
labels
Aug 31, 2023
connorskees
changed the title
feat(sequence): remove endpoint comparison helpers
chore(sequence): remove endpoint comparison helpers
Aug 31, 2023
This looks good. We should deprecate in main first since it'll merge conflict with this and add a changeset to that PR and this PR (just point people at |
Deprecation added in #17127 |
⯆ @fluid-example/bundle-size-tests: -190 Bytes
Baseline commit: 4c3325d |
Abe27342
approved these changes
Sep 20, 2023
This PR is ready to merge! Please review it and squash merge into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: dds: sharedstring
area: dds
Issues related to distributed data structures
base: next
PRs targeted against next branch
msftbot: merge-next
public api change
Changes to a public API
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove redundant endpoint comparison functions on interval helpers,
compareStarts
andcompareEnds
. We could reduce code churn by keeping these functions around and rewriting them in terms of the methods onIInterval
, but I think just removing them entirely is the nicer solution. The code churn should be minimal.Question for reviewers: should we deprecate these functions in
main
?