Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sequence): remove endpoint comparison helpers #17125

Merged
merged 5 commits into from
Sep 20, 2023

Conversation

connorskees
Copy link
Contributor

@connorskees connorskees commented Aug 31, 2023

Remove redundant endpoint comparison functions on interval helpers, compareStarts and compareEnds. We could reduce code churn by keeping these functions around and rewriting them in terms of the methods on IInterval, but I think just removing them entirely is the nicer solution. The code churn should be minimal.

Question for reviewers: should we deprecate these functions in main?

redundant with methods on IInterval
@connorskees connorskees requested review from msfluid-bot and a team as code owners August 31, 2023 16:53
@connorskees connorskees changed the title remove endpoint comparison helpers feat(sequence): remove endpoint comparison helpers Aug 31, 2023
@github-actions github-actions bot added area: dds Issues related to distributed data structures area: dds: sharedstring base: next PRs targeted against next branch labels Aug 31, 2023
@connorskees connorskees changed the title feat(sequence): remove endpoint comparison helpers chore(sequence): remove endpoint comparison helpers Aug 31, 2023
@connorskees connorskees requested a review from a team as a code owner August 31, 2023 16:56
@Abe27342
Copy link
Contributor

This looks good. We should deprecate in main first since it'll merge conflict with this and add a changeset to that PR and this PR (just point people at compareStart/compareEnd as you have)

@connorskees
Copy link
Contributor Author

Deprecation added in #17127

@msfluid-bot
Copy link
Collaborator

msfluid-bot commented Aug 31, 2023

@fluid-example/bundle-size-tests: -190 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 442.97 KB 442.88 KB -96 Bytes
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 237 KB 237 KB No change
loader.js 147.92 KB 147.92 KB No change
map.js 46.4 KB 46.4 KB No change
matrix.js 140.13 KB 140.13 KB No change
odspDriver.js 89.11 KB 89.11 KB No change
odspPrefetchSnapshot.js 41.78 KB 41.78 KB No change
sharedString.js 160.51 KB 160.42 KB -94 Bytes
sharedTree2.js 240.31 KB 240.31 KB No change
Total Size 1.65 MB 1.65 MB -190 Bytes

Baseline commit: 4c3325d

Generated by 🚫 dangerJS against c2ba8db

connorskees added a commit that referenced this pull request Sep 1, 2023
…Helpers (#17127)

Deprecates redundant methods on `IIntervalHelpers`. See
#17125 for their
subsequent removal and additional context.
@github-actions
Copy link
Contributor

This PR is ready to merge! Please review it and squash merge into next: @sonalideshpandemsft @tylerbutler @scottn12

@scottn12 scottn12 merged commit c362a65 into microsoft:next Sep 20, 2023
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dds: sharedstring area: dds Issues related to distributed data structures base: next PRs targeted against next branch msftbot: merge-next public api change Changes to a public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants