Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Port v2int 3.0] Rename TelemetryContext::SetAll to SetMultiple #14873

Conversation

agarwal-navin
Copy link
Contributor

Porting fa58a17 to release/v2int/3.0 as this is a breaking change. runtime-utils version 2.0.0-internal.3.0 running with runtime-definitions version 2.0.0-internal.3.2+ will not work because this change went into 2.0.0-internal.3.2.

#14070 added a setAll method to TelemetryContext that can be used to set mutliple values to the telemety context. As per #14153 (comment), renaming the method to setMultiple since its more inline with what it does.

@agarwal-navin agarwal-navin requested a review from a team as a code owner March 30, 2023 00:52
@github-actions github-actions bot added area: runtime Runtime related issues public api change Changes to a public API base: release PRs targeted against a release branch labels Mar 30, 2023
@msfluid-bot
Copy link
Collaborator

@fluid-example/bundle-size-tests: +30 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 426.78 KB 426.8 KB +15 Bytes
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 219.88 KB 219.9 KB +15 Bytes
loader.js 158.79 KB 158.79 KB No change
map.js 43.81 KB 43.81 KB No change
matrix.js 137.13 KB 137.13 KB No change
odspDriver.js 102.68 KB 102.68 KB No change
odspPrefetchSnapshot.js 42.35 KB 42.35 KB No change
sharedString.js 157.79 KB 157.79 KB No change
Total Size 1.35 MB 1.35 MB +30 Bytes

Baseline commit: 8456875

Generated by 🚫 dangerJS against 0d852e5

@agarwal-navin agarwal-navin merged commit 8c4ab26 into microsoft:release/v2int/3.0 Mar 30, 2023
@agarwal-navin agarwal-navin deleted the fixTelemetryContext_3.0 branch March 31, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: runtime Runtime related issues base: release PRs targeted against a release branch public api change Changes to a public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants