Fix detached cell test

microsoft · Jul 3, 2023 · 78083dc · 78083dc
1 parent b6e4fea
commit 78083dc
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/api-report/cell.api.md b/api-report/cell.api.md
@@ -51,7 +51,7 @@ export class SharedCell<T = any> extends SharedObject<ISharedCellEvents<T>> impl
     getAttribution(): AttributionKey | undefined;
     static getFactory(): IChannelFactory;
     // @alpha
-    static getFactory(options: CellOptions): IChannelFactory;
+    static getFactory(options?: CellOptions): IChannelFactory;
     protected initializeLocalCore(): void;
     // (undocumented)
     protected loadCore(storage: IChannelStorageService): Promise<void>;

diff --git a/packages/dds/cell/src/cell.ts b/packages/dds/cell/src/cell.ts
@@ -85,7 +85,7 @@ export class SharedCell<T = any>
 	 * time and do not apply to subsequent loads.
 	 * @alpha
 	 */
-	public static getFactory(options: CellOptions): IChannelFactory;
+	public static getFactory(options?: CellOptions): IChannelFactory;
 	public static getFactory(options?: CellOptions): IChannelFactory {
 		return new CellFactory(options);
 	}

diff --git a/packages/dds/cell/src/test/cell.spec.ts b/packages/dds/cell/src/test/cell.spec.ts
@@ -40,8 +40,8 @@ function createConnectedCell(
 function createDetachedCell(id: string, options?: CellOptions): ISharedCell {
 	const dataStoreRuntime = new MockFluidDataStoreRuntime();
 	dataStoreRuntime.options = options ?? dataStoreRuntime.options;
-	const subCell = new SharedCell(id, dataStoreRuntime, CellFactory.Attributes);
-	return subCell;
+	const factory = SharedCell.getFactory(options);
+	return new SharedCell(id, dataStoreRuntime, factory.attributes);
 }
 
 function createCellForReconnection(