Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

encode timeout msg in bytes #1078

Merged
merged 2 commits into from
Jun 12, 2023
Merged

encode timeout msg in bytes #1078

merged 2 commits into from
Jun 12, 2023

Conversation

sonichi
Copy link
Contributor

@sonichi sonichi commented Jun 12, 2023 •
edited
Loading

Why are these changes needed?

A simple fix to make sure the msg returned is always in bytes.

Related issue number

Checks

@sonichi sonichi temporarily deployed to openai June 12, 2023 03:48 — with GitHub Actions Inactive
@sonichi sonichi temporarily deployed to openai June 12, 2023 03:48 — with GitHub Actions Inactive
@sonichi sonichi temporarily deployed to openai June 12, 2023 03:48 — with GitHub Actions Inactive
@sonichi sonichi added this pull request to the merge queue Jun 12, 2023
Merged via the queue into main with commit c5dfb03 Jun 12, 2023
19 checks passed
@sonichi sonichi deleted the patch0611 branch June 12, 2023 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skzhang1 skzhang1 skzhang1 approved these changes

@yiranwu0 yiranwu0 yiranwu0 approved these changes

@BeibinLi BeibinLi Awaiting requested review from BeibinLi

@qingyun-wu qingyun-wu Awaiting requested review from qingyun-wu

@gagb gagb Awaiting requested review from gagb

@feiran-jia feiran-jia Awaiting requested review from feiran-jia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sonichi @skzhang1 @yiranwu0