Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Code Analysis issues #101

Merged
merged 6 commits into from
Aug 24, 2023
Merged

Fix Code Analysis issues #101

merged 6 commits into from
Aug 24, 2023

Conversation

calgagi
Copy link
Contributor

@calgagi calgagi commented Aug 15, 2023

Non-trivial fixes:
For CRootVisualizer::m_size, we were storing the 4 byte unsigned int as a 8-byte unsigned long long. Even though the API that it comes from uses unsigned int, and the API we use it for uses an unsigned int. So I just converted the whole thing to use unsigned int.

For CChildVisualizer::CreateEvaluationResult, we were passing in pType even though pType is always null. I just removed pType altogether and just pass in null.

Other fixes were simple (1 suppression, 1 cast to 64 bit int, 3 needed to have matching SAL notation as their declaration).

@gregg-miskelly
Copy link
Member

Including @xisui-MSFT

Copy link
Member

@gregg-miskelly gregg-miskelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments for requested changes.

@calgagi calgagi merged commit 9ff7a4e into microsoft:main Aug 24, 2023
3 checks passed
@calgagi
Copy link
Contributor Author

calgagi commented Aug 24, 2023

Thanks Gregg!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants