Bumped electron to 13.6.1 #2318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyanziano
requested review from
a-b-r-o-w-n,
compulim,
cwhitten,
srinaath and
tdurnford
as code owners
srinaath
reviewed
Nov 8, 2021
…t-specific config
tonyanziano
force-pushed
the
toanzian/electron-upgrade
branch
from
9a711d9
to
52df244
Compare
srinaath
approved these changes
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2295
===
Bumps
electronfrom11.0.1to13.6.1which includes a fix for the NodeJS bundled X3 cert which expired on Sept. 30th '21.This expired cert was causing outgoing HTTPS requests to URLs using a Let's Encrypt Cert (such as ngrok.io / ngrok.com) to throw a
CERT_EXPIREDerror which was breaking communication with remote bots.Changes (Based on the Electron Breaking Changes docs for versions 12 & 13)
contextIsolation: falsewere changed to include the property because the default was changed totruein version 12unlinkFile()command was changed to be async because the syncshell.moveItemToTrash()method was replaced with the asyncshell.trashItem()unlinkFile()does not need to be changed because it was already beingyield'ed in a generator function.