Fixed a bug that was causing Electron's context menu to fail #2238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyanziano
requested review from
a-b-r-o-w-n,
compulim,
corinagum,
cwhitten,
srinaath and
tdurnford
as code owners
srinaath
previously approved these changes
Mar 3, 2021
tonyanziano
added a commit
that referenced
this pull request
Mar 9, 2021
* Added ability to debug shared package (redux state). * Bumped Web Chat to 4.12.0 * Integrated inspector with new WC activity focus hook * Updated fallback speech service ponyfill API * Fixed WC send box overflow visual bug * Added changelog entry * v4.12.0 Release * Fixed opening files via electron's dialog API (#2237) * Fixed opening files via electron's dialog API * Added a changelog entry. * Fixed a bug that was causing Electron's context menu to fail (#2238) * Updated 4.12.0 release date * Fixed split button caret icon alignment (#2239) * Categorized 4.12.0 changes * Updated path to electron-builder hashFile utility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
showMenuAndWaitForInput()function was returning the entireElectron.MenuItemwhich contains functions as part of the object (click handler, etc.).With Electron 11, these cannot be sent over IPC back to the client side because functions cannot be serialized. This was causing the result to never make it back to the client side and for the context menu action to silently fail.
I changed the API to return an object containing solely the
idproperty of the selected menu item because all of the consumers of this API only care about theidproperty anyways.CI running here