Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Mac build by updating electron-builder and electron-updater #2230

Merged
merged 6 commits into from
Feb 11, 2021
Merged

Fixed Mac build by updating electron-builder and electron-updater #2230

merged 6 commits into from
Feb 11, 2021

Conversation

tonyanziano
Copy link
Contributor

The packaged Mac build was not opening correctly with the older version of electron-builder

@coveralls
Copy link

coveralls commented Feb 9, 2021 •
edited

Coverage Status

Coverage increased (+0.01%) to 67.782% when pulling 3aa2f02 on toanzian/mac-fix into cc523d3 on main.

corinagum
corinagum previously approved these changes Feb 10, 2021
View reviewed changes
Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tonyanziano tonyanziano merged commit f4c97be into main Feb 11, 2021
@tonyanziano tonyanziano deleted the toanzian/mac-fix branch February 11, 2021 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srinaath srinaath srinaath approved these changes

@corinagum corinagum corinagum left review comments

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@compulim compulim Awaiting requested review from compulim compulim is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@tdurnford tdurnford Awaiting requested review from tdurnford tdurnford is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tonyanziano @coveralls @srinaath @corinagum