-
Notifications
You must be signed in to change notification settings - Fork 750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom Activity Editor #2213
Merged
Merged
Custom Activity Editor #2213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srinaath
requested changes
Dec 29, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just minor comments.
packages/app/client/src/ui/dialogs/customActivityEditor/customActivityEditor.tsx
Outdated
Show resolved
Hide resolved
packages/app/client/src/ui/dialogs/customActivityEditor/customActivityEditor.tsx
Outdated
Show resolved
Hide resolved
packages/app/client/src/ui/dialogs/customActivityEditor/customActivityEditor.tsx
Outdated
Show resolved
Hide resolved
packages/app/client/src/ui/dialogs/customActivityEditor/customActivityEditorContainer.ts
Outdated
Show resolved
Hide resolved
This was referenced Dec 30, 2020
Thank you so much for this feature! This makes development so much faster since we would normally have to hook our local bot into another local application just to develop/test event related features. |
Glad I could help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom Activity Editor
Summary
Adds a new option to the "Conversation -> Send activity" menu that opens a dialog with an embedded JSON editor to allow the user to send custom activity payloads to their bot through the Emulator.
Includes a JSON schema based on the Bot Framework activity documentation in the OBI repo.
The JSON editor validates the content of the editor against this schema to ensure that no malformed activity payloads can be sent. (Can refine this as it gets more use.)
Fixes #2174, #1700
Possible features
Screenshots
Using the editor
Validation
Theming
![act4](https://user-images.githubusercontent.com/3452012/102925253-e0cf9780-4447-11eb-9ccf-3e50fb7969b1.PNG)