Fixed an issue that was causing adaptive card focus to be blurred whe… #2090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n clicking an activity.
tonyanziano
requested review from
a-b-r-o-w-n,
compulim,
corinagum,
cwhitten,
srinaath and
tdurnford
as code owners
srinaath
approved these changes
Mar 5, 2020
|
Awesome fix @tonyanziano |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n clicking an activity.
===
Fixes a regression of #1683
===
The problem:
When react-redux's
mapStateToPropsreturns an object with the newest version of a component's props, it does a shallow compare (===) of each of the new props' values with the previous props' values and if any of them return false, then it re-renders the component. Read more here.Since
currentUserwas being assigned to a new object ever timemapStateToPropswas run, even though the previouscurrentUserand the new one had the same key/value pairs.