Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled communication with remote Direct Line Speech bots #2079

Merged
merged 5 commits into from
Feb 20, 2020

Conversation

tonyanziano
Copy link
Contributor

@tonyanziano tonyanziano commented Feb 13, 2020

Fixes #2040

===

This PR adds the ability to connect to a remote Direct Line Speech bot by entering a speech key and speech region when connecting to a bot.

Example:

region: westus
key: some-speech-key-guid

image

@coveralls
Copy link

coveralls commented Feb 13, 2020

Coverage Status

Coverage increased (+0.1%) to 68.163% when pulling 252a43a on toanzian/dl-speech into 8ca1397 on master.

@tonyanziano
Copy link
Contributor Author

tonyanziano commented Feb 13, 2020

Linting is very unhappy due to a patch bump from eslint-plugin-import@2.20.0 to 2.20.1 as a side effect of regenerating the package-lock. This causes all of our import statements to fail linting resulting in a 400+ file change to satisfy the updated linter.

I'm going to make a separate PR that locks the eslint-plugin-import package to 2.20.0 so that we do not have to deal with this massive linting delta. (#2081 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify WebChat implementation to support connecting to a Direct Line Speech bot remotely
3 participants