Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made linkbutton of type button #2073

Merged
merged 4 commits into from
Jan 31, 2020
Merged

Conversation

srinaath
Copy link
Contributor

@srinaath srinaath commented Jan 31, 2020

Fixes #2031

===

angular/angular#12643

Without the type button inside the form. When an input is in focus the default HTML behavior is to pick the first button and trigger it when Enter key is pressed

Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
@coveralls
Copy link

coveralls commented Jan 31, 2020

Coverage Status

Coverage remained the same at 67.983% when pulling 0d9cc37 on srravich/bugfix/2031-entry-key into 8201114 on master.

Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Copy link
Contributor

@tonyanziano tonyanziano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@tonyanziano
Copy link
Contributor

This fixes #2031 I assume?

@srinaath
Copy link
Contributor Author

@tonyanziano correct. it fixes the opening of "Azure government" page when hitting enter

@srinaath srinaath merged commit 99be493 into master Jan 31, 2020
@srinaath srinaath deleted the srravich/bugfix/2031-entry-key branch February 26, 2020 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connecting to bot opens Azure Gov webpage
3 participants