[#1979] Enabled HTML-based app menu for Linux. #2020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyanziano
requested review from
a-b-r-o-w-n,
compulim,
corinagum and
cwhitten
as code owners
tonyanziano
force-pushed
the
toanzian/acc-#1979
branch
from
6e21894
to
710d634
Compare
corinagum
approved these changes
Dec 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1979
===
DO NOT MERGE UNTIL #2015 IS MERGEDGood to merge now 👍Switched from native application menu to HTML-based application menu on Linux for keyboard accessibility.
Due to a bug in Electron, disabling the native menu doesn't work like it does in Windows, and so there is an empty space at the top of application window where the menu would usually be. This is a small side effect.
electron/electron#16521