Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1952] Fixed recent bots keyboard nav issue. #2013

Merged
merged 2 commits into from
Dec 9, 2019
Merged

[#1952] Fixed recent bots keyboard nav issue. #2013

merged 2 commits into from
Dec 9, 2019

Conversation

tonyanziano
Copy link
Contributor

#1952

===

  • Old behavior would only show the close button on row item hover
  • New behavior shows the close button on row item hover, and also when the row item bot name is focused

Video:
1952-fix.zip

@coveralls
Copy link

coveralls commented Dec 6, 2019 •
edited

Coverage Status

Coverage remained the same at 68.758% when pulling 132fde0 on toanzian/acc-#1952 into 7e51dcf on master.

corinagum
corinagum previously approved these changes Dec 9, 2019
View reviewed changes
@tonyanziano tonyanziano merged commit 483f53f into master Dec 9, 2019
@tonyanziano tonyanziano deleted the toanzian/acc-#1952 branch December 9, 2019 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corinagum corinagum corinagum left review comments

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n

@compulim compulim Awaiting requested review from compulim

@cwhitten cwhitten Awaiting requested review from cwhitten

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tonyanziano @coveralls @corinagum