Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE#1904][MAS2.4.3] [Focus Order - Endpoint] Focus order is not logical under "Azure bot service configuration" dropdown. #1994

Merged
merged 3 commits into from
Nov 19, 2019
Merged

[ISSUE#1904][MAS2.4.3] [Focus Order - Endpoint] Focus order is not logical under "Azure bot service configuration" dropdown. #1994

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
26491a2
Add aria-hidden attribute to abs-config-content
Bill7zz Nov 19, 2019
d0e338a
Ädd changelog entry
denscollo Nov 19, 2019
b1a7fdc
Update CHANGELOG.md
tonyanziano Nov 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- [1983](https://github.com/microsoft/BotFramework-Emulator/pull/1983)
- [1990](https://github.com/microsoft/BotFramework-Emulator/pull/1990)
- [1991](https://github.com/microsoft/BotFramework-Emulator/pull/1991)
- [1994](https://github.com/microsoft/BotFramework-Emulator/pull/1994)

## Removed
- [main] Removed unused `VersionManager` class in PR [1991](https://github.com/microsoft/BotFramework-Emulator/pull/1991)
Expand Down
9 changes: 8 additions & 1 deletion packages/app/client/src/ui/shell/explorer/endpointExplorer/endpointEditor/endpointEditor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,13 @@ export class EndpointEditor extends Component<EndpointEditorProps, EndpointEdito
Azure Bot Service configuration
<span role="presentation"></span>
</button>
<div id="abs-config-content" className={styles.absContent} ref={this.absContentRef} role="region">
<div
id="abs-config-content"
className={styles.absContent}
ref={this.absContentRef}
role="region"
aria-hidden={true}
>
<div>
<Row className={styles.absTextFieldRow}>
<TextField
Expand Down Expand Up @@ -307,6 +313,7 @@ export class EndpointEditor extends Component<EndpointEditorProps, EndpointEdito
const newHeight = expanded ? clientHeight : 0;
this.absContent.style.height = `${newHeight}px`;
currentTarget.setAttribute('aria-expanded', expanded + '');
this.absContent.setAttribute('aria-hidden', expanded ? 'false' : 'true');
this.absContent.querySelectorAll('input').forEach((node: HTMLElement) => {
if (node.hasAttribute('tabIndex')) {
node.setAttribute('tabIndex', expanded ? '0' : '-1');
Expand Down