Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1730] Fixed open bot dialog url validation a11y issue. #1918

Merged
merged 1 commit into from
Oct 8, 2019

Conversation

tonyanziano
Copy link
Contributor

@tonyanziano tonyanziano commented Oct 8, 2019

#1846 #1730

===

  • Removed ARIA alerts for Bot URL validation
  • Added functionality to <AutoComplete /> component so that it properly narrates any error messages

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 65.917% when pulling c8a8884 on toanzian/acc-#1846 into c53ac1d on master.

Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tonyanziano tonyanziano merged commit 98e7b21 into master Oct 8, 2019
@tonyanziano tonyanziano deleted the toanzian/acc-#1846 branch October 8, 2019 17:18
@tonyanziano tonyanziano changed the title [#1846] Fixed open bot dialog url validation a11y issue. [#1730] Fixed open bot dialog url validation a11y issue. Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants