Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1753 fix focus indicator on file upload button #1855

Merged
merged 3 commits into from
Sep 10, 2019
Merged

Conversation

corinagum
Copy link
Contributor

image

#1753

Previously the focus indicator on the File Upload button in chat was not showing up. This fix now shows the focus, as seen above.

@@ -31,7 +31,9 @@
"prettier": "^1.15.3"
},
"jest": {
"setupFilesAfterEnv": ["./testSetup.js"],
"setupFilesAfterEnv": [
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just FYI, this change was by the linter, not me.

tonyanziano
tonyanziano previously approved these changes Sep 10, 2019
Copy link
Contributor

@tonyanziano tonyanziano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@coveralls
Copy link

coveralls commented Sep 10, 2019

Coverage Status

Coverage increased (+0.005%) to 65.775% when pulling 33b400c on corinagum/1753 into e434a70 on master.

@corinagum
Copy link
Contributor Author

@tonyanziano test fixed, sorry about that

Copy link
Contributor

@tonyanziano tonyanziano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@tonyanziano tonyanziano merged commit 7bccc93 into master Sep 10, 2019
@tonyanziano tonyanziano deleted the corinagum/1753 branch September 10, 2019 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants