Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1800] Fixed invisible links within service dialog. #1843

Merged
merged 1 commit into from
Sep 6, 2019
Merged

[#1800] Fixed invisible links within service dialog. #1843

merged 1 commit into from
Sep 6, 2019

Conversation

tonyanziano
Copy link
Contributor

@tonyanziano tonyanziano commented Sep 5, 2019 •
edited
Loading

#1800

===

Some links within the service dialogs were missing text and eating focus when using keyboard navigation, which was not accessible.

Before:

image

image

After:

image

image

corinagum
corinagum approved these changes Sep 5, 2019
View reviewed changes
Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Toit

@coveralls
Copy link

Coverage Status

Coverage remained the same at 65.765% when pulling 6f3c641 on toanzian/acc-#1800 into daa8f6b on master.

@tonyanziano tonyanziano merged commit f86a0d3 into master Sep 6, 2019
@tonyanziano tonyanziano deleted the toanzian/acc-#1800 branch September 6, 2019 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corinagum corinagum corinagum approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n

@compulim compulim Awaiting requested review from compulim

@cwhitten cwhitten Awaiting requested review from cwhitten

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tonyanziano @coveralls @corinagum