Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1724, #1741, #1805] Fix up focus trap for dialogs #1829

Merged
merged 16 commits into from
Sep 10, 2019
Merged

[#1724, #1741, #1805] Fix up focus trap for dialogs #1829

merged 16 commits into from
Sep 10, 2019

Conversation

corinagum
Copy link
Contributor

@corinagum corinagum commented Sep 4, 2019 •
edited
Loading

#1724, #1741, #1805

Before undrafting this issue:

This fixes the focus trap on dialogs.

@corinagum corinagum changed the title Fix up focus trap for dialogs [#1724, #1741] Fix up focus trap for dialogs Sep 4, 2019
@corinagum corinagum mentioned this pull request Sep 4, 2019
Closed
@coveralls
Copy link

coveralls commented Sep 4, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.01%) to 65.784% when pulling b363ca3 on corinagum/1741 into 6fe9dff on master.

@tonyanziano
Copy link
Contributor

#1805 is related as well

@corinagum corinagum changed the title [#1724, #1741] Fix up focus trap for dialogs [#1724, #1741, #1805] Fix up focus trap for dialogs Sep 6, 2019
@corinagum
Copy link
Contributor Author

working on the tests now.

@corinagum corinagum marked this pull request as ready for review September 9, 2019 19:09
@corinagum
Copy link
Contributor Author

This is ready for review. :)

tonyanziano
tonyanziano suggested changes Sep 9, 2019
View reviewed changes
Copy link
Contributor

@tonyanziano tonyanziano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Had some minor nitpicks.

packages/app/client/package.json Show resolved Hide resolved
packages/app/client/src/ui/dialogs/host/host.tsx Outdated Show resolved Hide resolved
packages/app/client/src/ui/dialogs/host/host.tsx Outdated Show resolved Hide resolved
packages/app/main/e2e/navigateADialog.spec.ts Show resolved Hide resolved
packages/app/main/e2e/navigateADialog.spec.ts Outdated Show resolved Hide resolved
packages/app/main/e2e/navigateADialog.spec.ts Outdated Show resolved Hide resolved
@corinagum
Copy link
Contributor Author

@tonyanziano ping, build/tests are passing. thanks for your patience

@tonyanziano tonyanziano merged commit 7c9e2bd into master Sep 10, 2019
@tonyanziano tonyanziano deleted the corinagum/1741 branch September 10, 2019 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyanziano tonyanziano tonyanziano approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n

@compulim compulim Awaiting requested review from compulim

@cwhitten cwhitten Awaiting requested review from cwhitten

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@corinagum @coveralls @tonyanziano