[#1742] Overflow visible on row to show focus borders #1790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corinagum
requested review from
a-b-r-o-w-n,
compulim,
cwhitten and
tonyanziano
as code owners
corinagum
changed the title
tonyanziano
previously approved these changes
Sep 4, 2019
There was a problem hiding this comment.
I thought this might have some unforeseen consequences when resizing the app (horizontal scrollbars), but I messed around with it and I couldn't find anything.
The only other alternative fix other than overflow that I can think of would be to add a small padding inside of all the rows to accommodate any focus outlines, but that seems worse.
We'll just have to keep an eye out for any strange behavior where <Row />'s are involved.
|
@tonyanziano ping on this guy :) |
tonyanziano
approved these changes
Sep 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1742
Fix appearance of bot creation dialog anchors, which were previously not showing the entire boxed border on focus. This fix removes
overflow:hiddenfrom the Row component.This is how the the dialog looks now: