Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Further deprecate OTel and Brave Http instrumentations #371

Closed
marcingrzejszczak opened this issue Sep 29, 2023 · 0 comments · Fixed by #486
Closed

Further deprecate OTel and Brave Http instrumentations #371

marcingrzejszczak opened this issue Sep 29, 2023 · 0 comments · Fixed by #486
Labels
type: task A general task
Milestone
1.3.0-M1

Comments

@marcingrzejszczak
Copy link
Contributor

marcingrzejszczak commented Sep 29, 2023 •
edited
Loading

Add warning messages and timeouts?

Related:
@marcingrzejszczak marcingrzejszczak added this to the 1.3.0-M1 milestone Sep 29, 2023
@marcingrzejszczak marcingrzejszczak mentioned this issue Sep 29, 2023
Closed
@marcingrzejszczak marcingrzejszczak added the type: task A general task label Sep 29, 2023
marcingrzejszczak added a commit that referenced this issue Dec 8, 2023
@marcingrzejszczak
Further deprecate the handler API
5892b02 
whenever the deprecated API is being used

- added logging of warnings
- added 5 second timeout

also removed any calls to the deprecated API from the existing integration tests. That's a breaking change in the way that we're not creating the default handlers in testing framework. I think that's fine cause we haven't setup any functionality for it neither have we documented any of its usage anywhere

fixes gh-371
@marcingrzejszczak marcingrzejszczak mentioned this issue Dec 8, 2023
Merged
marcingrzejszczak added a commit that referenced this issue Dec 8, 2023
@marcingrzejszczak
Further deprecate the handler API
fce71d2 
whenever the deprecated API is being used

- added logging of warnings
- added 5 second timeout

also removed any calls to the deprecated API from the existing integration tests. That's a breaking change in the way that we're not creating the default handlers in testing framework. I think that's fine cause we haven't setup any functionality for it neither have we documented any of its usage anywhere

fixes gh-371
marcingrzejszczak added a commit that referenced this issue Dec 8, 2023
@marcingrzejszczak
Further deprecate the handler API
d805502 
- whenever the deprecated API is being used added logging of warnings
- also removed any calls to the deprecated API from the existing integration tests. That's a breaking change in the way that we're not creating the default handlers in testing framework. I think that's fine cause we haven't setup any functionality for it neither have we documented any of its usage anywhere

fixes gh-371
marcingrzejszczak added a commit that referenced this issue Dec 8, 2023
@marcingrzejszczak
Further deprecate the handler API (#486)
9a05da9 
- whenever the deprecated API is being used added logging of warnings
- also removed any calls to the deprecated API from the existing integration tests. That's a breaking change in the way that we're not creating the default handlers in testing framework. I think that's fine cause we haven't setup any functionality for it neither have we documented any of its usage anywhere

fixes gh-371
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: task A general task
Projects
None yet
Milestone
1.3.0-M1
Development

Successfully merging a pull request may close this issue.

Further deprecate the handler API micrometer-metrics/tracing
1 participant
@marcingrzejszczak