Update dynatrace-metric-utils-java to 2.1.0 #4565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arminru
approved these changes
Jan 12, 2024
shakuzen
added
registry: dynatrace
shakuzen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In https://github.com/dynatrace-oss/dynatrace-metric-utils-java/releases/tag/v2.1.0, we introduced an additional check to validate data before sending it to the Dynatrace API (the changeset is here). The Dynatrace API will reject data if it does not conform to this specification, and will return an error response. It is currently rather complicated to extract the offending metric name from the error response. This change will help us log offending metric names directly on the client side, and also save network bandwidth for metrics that we already know will be rejected on the API side.
Please note that this update does not change which data is stored in Dynatrace and merely shifts the validation to the client side.