Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use JUnit Jupiter for JerseyTest tests #2852

Closed
wants to merge 1 commit into from

Conversation

izeye
Copy link
Contributor

@izeye izeye commented Nov 9, 2021

This PR changes to use JUnit Jupiter for JerseyTest tests as eclipse-ee4j/jersey#3662 seems to be resolved via eclipse-ee4j/jersey#4824 since 2.35.

This PR also removes dependency management for JUnit 4 as it's not used anymore.

This commit also removes dependency management for JUnit 4 as it's not used anymore.
Copy link
Member

@jonatan-ivanov jonatan-ivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to rebase this to 1.8.x

@jonatan-ivanov jonatan-ivanov added enhancement A general enhancement module: micrometer-test An issue that is related to our TCK labels Nov 10, 2021
@jonatan-ivanov jonatan-ivanov added this to the 1.8.0 milestone Nov 10, 2021
@jonatan-ivanov
Copy link
Member

Committed in e05f3e5

Thank you very much!

@izeye
Copy link
Contributor Author

izeye commented Nov 10, 2021

@jonatan-ivanov Thanks!

This isn't a user-facing change, so the type: task label seems to be more appropriate than the enhancement one, especially considering the way of generating release notes.

@izeye izeye deleted the jersey branch November 10, 2021 01:02
@jonatan-ivanov jonatan-ivanov added type: task A general task and removed enhancement A general enhancement labels Nov 10, 2021
@jonatan-ivanov
Copy link
Member

Yepp, you are right, thank you!

@mweirauch
Copy link
Contributor

Thanks for taking care of this! I was watching the original issue, but there was no activity, yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: micrometer-test An issue that is related to our TCK type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants