Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WavefrontMeterRegistryTest.configureDefaultSenderWithCustomConfig() #2849

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

izeye
Copy link
Contributor

@izeye izeye commented Nov 8, 2021

It fails as follows:

WavefrontMeterRegistryTest > configureDefaultSenderWithCustomConfig() FAILED
    org.assertj.core.util.introspection.IntrospectionError: 
    Can't find any field or property with name 'reportingService'.
    Error when introspecting properties was :
    - No getter for property 'reportingService' in com.wavefront.sdk.common.clients.WavefrontClient 
    Error when introspecting fields was :
    - Unable to obtain the value of the field <'reportingService'> from <com.wavefront.sdk.common.clients.WavefrontClient@7afb1741>
        at app//org.assertj.core.util.introspection.PropertyOrFieldSupport.getSimpleValue(PropertyOrFieldSupport.java:88)
        at app//org.assertj.core.util.introspection.PropertyOrFieldSupport.getValueOf(PropertyOrFieldSupport.java:60)
        at app//org.assertj.core.extractor.ByNameSingleExtractor.apply(ByNameSingleExtractor.java:29)
        at app//org.assertj.core.api.AbstractAssert.extracting(AbstractAssert.java:1059)
        at app//org.assertj.core.api.AbstractObjectAssert.extracting(AbstractObjectAssert.java:834)
        at app//io.micrometer.wavefront.WavefrontMeterRegistryTest.configureDefaultSenderWithCustomConfig(WavefrontMeterRegistryTest.java:175)

        Caused by:
        org.assertj.core.util.introspection.IntrospectionError: Unable to obtain the value of the field <'reportingService'> from <com.wavefront.sdk.common.clients.WavefrontClient@7afb1741>
            at app//org.assertj.core.util.introspection.FieldSupport.readSimpleField(FieldSupport.java:248)
            at app//org.assertj.core.util.introspection.FieldSupport.fieldValue(FieldSupport.java:202)
            at app//org.assertj.core.util.introspection.PropertyOrFieldSupport.getSimpleValue(PropertyOrFieldSupport.java:70)
            ... 5 more

            Caused by:
            java.lang.IllegalArgumentException: Cannot locate field reportingService on class com.wavefront.sdk.common.clients.WavefrontClient
                at org.assertj.core.util.Preconditions.checkArgument(Preconditions.java:129)
                at org.assertj.core.util.introspection.FieldUtils.readField(FieldUtils.java:144)
                at org.assertj.core.util.introspection.FieldSupport.readSimpleField(FieldSupport.java:208)
                ... 7 more

reportingService seems to be split into metricsReportingService and tracesReportingService in the recent Wavefront library as follows:

  private final ReportingService metricsReportingService;
  private final ReportingService tracesReportingService;

@izeye izeye changed the title Fix `WavefrontMeterRegistryTest.configureDefaultSenderWithCustomConfig() Fix WavefrontMeterRegistryTest.configureDefaultSenderWithCustomConfig() Nov 8, 2021
@shakuzen shakuzen added registry: wavefront A Wavefront (Tanzu Observability) Registry related issue type: task A general task labels Nov 8, 2021
@shakuzen shakuzen merged commit 5e9bcfc into micrometer-metrics:main Nov 8, 2021
@izeye izeye deleted the wavefront branch November 8, 2021 03:48
jonatan-ivanov pushed a commit that referenced this pull request Nov 8, 2021
@jonatan-ivanov jonatan-ivanov added this to the 1.8.0 milestone Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
registry: wavefront A Wavefront (Tanzu Observability) Registry related issue type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants