Migrate Jersey instrumentation into micrometer-core #2780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Jersey instrumentation has been updated to support both Jersey 2 and Jersey 3. It is confusing to have this in a micrometer-jersey2 module, and it would be more in line with our other instrumentation if it lived in micrometer-core.
Use the Jersey code in core rather than the deprecated micrometer-jersey2 module.
shakuzen
added
enhancement
jonatan-ivanov
approved these changes
Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the code in the micrometer-jersey2 module to micrometer-core. Recently the code was updated so it can support Jersey 2 and Jersey 3. It is confusing to have Jersey 3 support in the micrometer-jersey2 module, and it is more in line with other instrumentation we have for it to be in core. The micrometer-jersey2 module is deprecated and users should update their imports to use the same classes now in the micrometer-core module.
The jersey3 sample is updated to show this being used.