Remove trailing commas from CREATE TABLE statements #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daemonsy
changed the title
|
Yes, this is a bug on my part. SQL syntax can't have trailing commas on the last items. With MySQL at least. Also, fwiw, we're only supporting MySQL >= 8 feature set (>= 8.0.19 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's up?
Was having problems running the schema.sql file in MySQL 5.7.32. It was blowing up because of the trailing commas.
Did some research on whether trailing commas are allowed in
CREATE TABLE. The results didn't seem conclusive. Some RDBMS implementations deem it harmless and won't error on it.Wanted to check the SQL language spec next but since this file has some statement without trailing commas, I thought it's probably not intentional and it's easier to just remove it.