-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Import taxpasta #574
WIP: Import taxpasta #574
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, let me know if you need help with the documentation
3053df2
to
a0c1a5c
Compare
Thank you for the detailed review @TuomasBorman! I have some open questions from your comments and will appreciate your assistance with the documentation. It's not clear to me why to break up the docstring like that for a single function and how to direct |
Hi @TuomasBorman, Starting next week, I will have more time again and could try to complete this PR. I would need some advice and decisions from your side, though, please. If you can take another look, I will be grateful. |
Alright, sounds good. I have also been busy, but I will check during this week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good already
@TuomasBorman, I believe, I have addressed all of your comments. Please have another look and let me know if there's something else to be addressed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #574 +/- ##
========================================
Coverage ? 68.04%
========================================
Files ? 43
Lines ? 5194
Branches ? 0
========================================
Hits ? 3534
Misses ? 1660
Partials ? 0 ☔ View full report in Codecov by Sentry. |
To do:
biomformat:::
. I see no way around this at the moment.