Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable bindgen default features #3

Merged
merged 2 commits into from
Oct 25, 2022
Merged

Conversation

vorot93
Copy link
Contributor

@vorot93 vorot93 commented Sep 28, 2022

No description provided.

@michaellass
Copy link
Owner

Sorry for the late reply. For some reason github did not notify me of this PR. Could you please elaborate on this change, i.e., what the change in behavior will be and why this is desired?

@vorot93
Copy link
Contributor Author

vorot93 commented Oct 24, 2022

Stop pulling in unnecessary deps like clap

@michaellass
Copy link
Owner

michaellass commented Oct 24, 2022

Why do you change the caret expression of the version to a fixed version? What features are deactivated by this and why are they not required for this crate? Are selectable features of bindgen documented anywhere? Again: Could you please elaborate on this change, i.e., what the change in behavior will be and why this is desired? I won't merge changes that are not self-explanatory or explained.

@vorot93
Copy link
Contributor Author

vorot93 commented Oct 24, 2022

  1. Caret are default requirements in Cargo
  2. Not sure about documentation, but those features are not for e2p's context.
  3. No there won't be any change of behaviour.

@michaellass michaellass merged commit c3335c3 into michaellass:master Oct 25, 2022
@michaellass
Copy link
Owner

Thank you. Turns out that in bindgen 0.61 the command line interface was extracted into its own crate so that bindgen itself has now way fewer depdendencies: rust-lang/rust-bindgen#2284
Features that are still disabled by this PR are logging and which-rustfmt which bring additional depdendencies on log and which (see https://github.com/rust-lang/rust-bindgen/blob/v0.61.0/bindgen/Cargo.toml#L30). So this change still reduces the dependency tree a bit.

I wasn't aware that caret and simple version specification are identical. Seems that simple version strings are now the recommended way to go: rust-lang/cargo#10158

Merged with those additional information added to the commit message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants