Fix handling of default/empty log level #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set $verbose to an empty string if no acceptable log level was passed. Then unquote the resulting string in the exec command so that it can expand to nothing. The contents are already sanitised so we shouldn't need to worry about quoting any value. Added examples of the three "known" logging levels that are parsed. With the default configuration of `LOGSTASH_LOGLEVEL=warn` the wrapper script was not setting the $verbose variable. The resulting command then featured a pair of quotes with no contents inside: `""` The logstash JAR rejected this with: ``` No such command "" Available commands: -v -V --version agent web test irb pry ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set $verbose to an empty string if no acceptable log level was passed. Then
unquote the resulting string in the exec command so that it can expand to
nothing. The contents are already sanitised so we shouldn't need to worry
about quoting any value.
Added examples of the three "known" logging levels that are parsed.
With the default configuration of
LOGSTASH_LOGLEVEL=warnthe wrapperscript was not setting the $verbose variable. The resulting command then
featured a pair of quotes with no contents inside:
""The logstash JAR rejected this with: