Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #911 #912

Merged
merged 1 commit into from
Mar 15, 2022
Merged

Fix for issue #911 #912

merged 1 commit into from
Mar 15, 2022

Conversation

bezrodnov
Copy link
Contributor

This change should address the performance issue #911 where parsing a file with a lot of empty rows takes more time than expected when skipEmptyLines option is set to greedy.

@pokoli
Copy link
Collaborator

pokoli commented Jan 13, 2022

Hi @bezrodnov,

Thanks for your PR, it looks good to me but I see you updated the minified version and this is something that we just do on the release processs. Could you please revert this change? Thanks

@bezrodnov
Copy link
Contributor Author

Hi @pokoli,

Sorry, I did not know if I should build the minified version or not and that's why I put it in a different commit (so that I can easily revert it).

I've removed the minified version from the PR, could you please have a look? 🙂

@julienavert
Copy link

Hi and thanks to everyone involved for their work 🙂

I would like to know if there is an estimation of when this fix is going to be merged and published in a new version.

@pokoli
Copy link
Collaborator

pokoli commented Mar 14, 2022

Hi @bezrodnov ,

We have introduced some fixes on our CI on the master branch, before merging this PR i will like to run the test suite with the latest configuration. Could you please merge the master branch on your changes?

@julienavert sorry for the delay, we have some PR that should be reviewed and merged. Once they land on the master land I will publish a new version containing the fixes.

@bezrodnov
Copy link
Contributor Author

Hi @pokoli,

Thank you for coming back! 🙂
I've updated the PR with the latest changes from master. Could you please run the CI pipeline on it?

@pokoli pokoli merged commit a93c5c9 into mholt:master Mar 15, 2022
@pokoli
Copy link
Collaborator

pokoli commented Mar 15, 2022

@bezrodnov it's already merged. Thanks for your contribution!

@pokoli
Copy link
Collaborator

pokoli commented Mar 15, 2022

@julienavert I just published 5.3.2 on npm which contains this fix (among others).
Hope this helps!

@bezrodnov bezrodnov deleted the #911 branch March 18, 2022 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants