Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Rust 2018 compatibility #85

Merged
merged 4 commits into from
Mar 30, 2020
Merged

Conversation

mgeisler
Copy link
Owner

I've been trying to keep the crate compatible with Rust 2018, which
corresponds to Rust version 1.31.0. However, this has proven
impossible because of how our dependencies keep releasing new patch
versions that push up the minimum required Rust version.

Because of this, the current code no longer compiles with Rust 1.31.0
because cargo sync will pull in too new versions of the direct and
transitive dependencies. This happens even if there are no changes in
version-sync.

The failure to compile shows up as spurious and unexpected build
failures in our CI, which in turn makes it hard to trust CI.

I'm concluding that it's infeasible to keep version-sync compatible
with any particular version of Rust. While not perfect, we'll track
the latest stable version of Rust from now on. This is not perfect
since even stable Rust sometimes decides to turn warnings into hard
errors: rust-lang/rust#64221

@mgeisler mgeisler force-pushed the drop-rust-2018-compatibility branch from 57da168 to 7b594ab Compare March 30, 2020 13:52
I've been trying to keep the crate compatible with Rust 2018, which
corresponds to Rust version 1.31.0. However, this has proven
impossible because of how our dependencies keep releasing new patch
versions that push up the minimum required Rust version.

Because of this, the current code no longer compiles with Rust 1.31.0
because `cargo sync` will pull in too new versions of the direct and
transitive dependencies. This happens even if there are no changes in
`version-sync`.

The failure to compile shows up as spurious and unexpected build
failures in our CI, which in turn makes it hard to trust CI.

I'm concluding that it's infeasible to keep `version-sync` compatible
with any particular version of Rust. While not perfect, we'll track
the latest stable version of Rust from now on. This is not perfect
since even stable Rust sometimes decides to turn warnings into hard
errors: rust-lang/rust#64221
@mgeisler mgeisler force-pushed the drop-rust-2018-compatibility branch from 7b594ab to 908b501 Compare March 30, 2020 13:57
The nightly tests have never managed to catch something. Since
AppVeyor runs our tests one at a time, we can save some time by only
running nightly tests in Linux (on Travis CI).
This takes advantage of the default match bindings in Rust 2018.
@mgeisler mgeisler merged commit 9101abd into master Mar 30, 2020
@mgeisler mgeisler deleted the drop-rust-2018-compatibility branch February 14, 2021 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant