Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update weightNode_io.py #267

Merged
merged 2 commits into from
Sep 9, 2023
Merged

Update weightNode_io.py #267

merged 2 commits into from
Sep 9, 2023

Conversation

ordinc
Copy link
Contributor

@ordinc ordinc commented Sep 7, 2023

Fixed the uninstallation of the "weightDriver" plug-in in the python3 environment (maya2023, maya2024) because the "weightDriver/plug-ins" in line 131 is not in the list on line 130, so the variable value in line 132 is None, This error occurs when comparing row 134. # Error: TypeError: '>' not supported between instances of 'NoneType' and 'str' #

Fixed the uninstallation of the "weightDriver" plug-in in the python3 environment (maya2023, maya2024) because the "weightDriver/plug-ins" in line 131 is not in the list on line 130, so the variable value in line 132 is None, This error occurs when comparing row 134. # Error: TypeError: '<' not supported between instances of 'NoneType' and 'str' #
@ordinc ordinc closed this Sep 7, 2023
@ordinc ordinc reopened this Sep 7, 2023
@ordinc
Copy link
Contributor Author

ordinc commented Sep 7, 2023

This update fixes the inability to create the "Enable mGear file drop" and "Help" submenus in the mgear menu due to this bug.
The following pictures are from maya2024.
before:
image

after:
image

If "weightDriver/plug-ins" does not exist in the user's plug-in list, it will cause the above-mentioned incomplete menu creation error.

@miquelcampos
Copy link
Member

Hi @ordinc thanks for the PR
I wonder why I didn't see the error before. Maybe is related if you have or have not installed the plugin SHAPES? Do you have this plugin installed?
My menu without your fix looks good
image
@SimonBenAnderson @ireneweng Can you confirm if you have this issue on your side? Thanks

@ordinc
Copy link
Contributor Author

ordinc commented Sep 7, 2023

Maybe is related if you have or have not installed the plugin SHAPES? Do you have this plugin installed?

Maybe yes, I have SHAPES installed in the 2020 environment, but not in the 2024 environment, so when I installed the latest version of mGear in these two versions, I found that the mGear menu in 2020 is complete, and in 2024 The mGear menu is incomplete (as shown in the screenshot in my previous review).

My menu without your fix looks good

Maybe SHAPES is installed in your current version environment?

@miquelcampos
Copy link
Member

Yes I have SHAPES installed in all my Maya versions 😅

@miquelcampos miquelcampos merged commit 7fbe1ea into mgear-dev:master Sep 9, 2023
1 check failed
miquelcampos added a commit that referenced this pull request Sep 9, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 4.1.1
Development

Successfully merging this pull request may close these issues.

2 participants