Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added info for the user if (un)installation fails. #247

Merged
merged 2 commits into from
Sep 1, 2023

Conversation

chelloiaco
Copy link
Contributor

Hey,

Just some minor changes to the drag_n_drop_install.py file to include better error handling.
I personally dealt with being confused as to why the plugin wasn't working even though I was getting a Loaded mgear_solvers.mll plugin and Installation Complete messages.

I added some docstrings to the functions I altered, but instead of following the convention recommended in the CONTRIBUTING.md, I just went with what the rest of the .py file had, for consistency. I can convert all to Google Napoleon if needed at a future pull request.

This is my very first code contribution and pull request, so bare with me and please let me know if anything is out of protocol.

@miquelcampos
Copy link
Member

Hi @chelloiaco Thanks for the PR I will check it and merge ASAP

@miquelcampos miquelcampos added the enhancement New feature or request label Jul 10, 2023
@miquelcampos miquelcampos self-assigned this Jul 10, 2023
@miquelcampos miquelcampos merged commit 12d6b58 into mgear-dev:master Sep 1, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 4.1.x
Development

Successfully merging this pull request may close these issues.

2 participants