Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix private information disclosure #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix private information disclosure #7

wants to merge 1 commit into from

Conversation

alexcoman
Copy link

Travis-CI will log every command and in order to avoid information disclosure the command should not contain plain text data.

With this patch the log will look like:

** Execute site:deploy
git config --global user.name '$GIT_NAME'
git config --global user.email '$GIT_EMAIL'
git config --global push.default simple
git clone https://$GIT_NAME:$GH_TOKEN@github.com/[...]

and without it:

** Execute site:deploy
git config --global user.name 'username'
git config --global user.email 'email@test.com'
git config --global push.default simple
git clone https://username:189d6......fd4c948@github.com/....

Thanks,
Alex

Travis-CI will log every command and in order to avoid information
disclosure the command should not contain plain text data.
@jmatsushita
Copy link

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants