Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate config.ts #112

Closed
3 of 7 tasks
meyfa opened this issue Jul 11, 2022 · 0 comments · Fixed by #411
Closed
3 of 7 tasks

Eliminate config.ts #112

meyfa opened this issue Jul 11, 2022 · 0 comments · Fixed by #411
Assignees
@meyfa
Labels
enhancement New feature or request

Comments

@meyfa
Copy link
Owner

meyfa commented Jul 11, 2022 •
edited

Configuration via a source file is bad for multiple reasons:

  • Changes to the config must be recompiled
  • It gets the cloned Git repository out of sync
  • It doesn't really work with Docker

Most of the settings aren't needed anyway. I suggest removing them entirely, and converting others to environment variables, which are a more portable and standardized alternative.

Related issues:
@meyfa meyfa added the enhancement New feature or request label Jul 11, 2022
@meyfa meyfa mentioned this issue Sep 20, 2022
Merged
meyfa added a commit that referenced this issue Sep 20, 2022
@meyfa
feat!: Remove CORS option from config.ts
5ff1295 
With the goal of eliminating config.ts (ref #112), the CORS settings are
now only available via env variables, and no longer via the config file.
@meyfa meyfa mentioned this issue Sep 20, 2022
Merged
meyfa added a commit that referenced this issue Sep 20, 2022
@meyfa
feat!: Remove CORS option from config.ts (#147)
d9de9d2 
With the goal of eliminating config.ts (ref #112), the CORS settings are
now only available via env variables, and no longer via the config file.
@meyfa meyfa self-assigned this Jul 23, 2024
meyfa added a commit that referenced this issue Jul 23, 2024
@meyfa
feat!: Use environment variables for configuration (exclusively)
f96685e 
Fixes #112. `config.ts` is no longer part of the configuration workflow
when deploying the application. Instead, everything is configurable
through environment variables. See #112 for further reasoning.
@meyfa meyfa mentioned this issue Jul 23, 2024
Merged
@meyfa meyfa closed this as completed in 18756e9 Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meyfa meyfa

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: Use environment variables for configuration (exclusively) meyfa/ka-mensa-api
1 participant
@meyfa