Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix seek to end of stream #73

Merged
merged 3 commits into from
Aug 11, 2024
Merged

Conversation

MarkKremer
Copy link
Collaborator

@MarkKremer MarkKremer commented Aug 8, 2024

This PR adds 2 testcases:

  • Seek to last sample of file (still broken, commented out).
  • Seek to sample after last sample (failed & now fixed).

I've moved my problem description and possible solutions & drawbacks for the first testcase to #74.

Contains one fixed & one still failing test.
MarkKremer added a commit to gopxl/beep that referenced this pull request Aug 11, 2024
Copy link
Member

@mewmew mewmew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mewmew mewmew merged commit 2c1c29d into mewkiz:master Aug 11, 2024
2 checks passed
@MarkKremer MarkKremer deleted the fix-seek-end-of-stream branch August 11, 2024 19:46
MarkKremer added a commit to gopxl/beep that referenced this pull request Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants