Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No "Cancel" button for DataSource Settings #455

Open
akvlad opened this issue Jun 26, 2024 · 0 comments
Open

No "Cancel" button for DataSource Settings #455

akvlad opened this issue Jun 26, 2024 · 0 comments
Assignees
Labels
bug Something isn't working in review

Comments

@akvlad
Copy link
Contributor

akvlad commented Jun 26, 2024

Describe the bug.

You can't cancel datasource settings change without saving.

Reproduction

  1. Open qryn-view
  2. Go to "Datasource Settings"
  3. Add custom HTTP Header
  4. Start typing the header name

AR: The "Back" button is replaced to "Save", "Back" button is disappeared.
ER: There should be a way to go back without saving.

AR: There is a "Saved" green icon on the "Custom HTTP Headers" line, while "Save" button is also present
ER: The Datasource Settings page should either follow the "Autosave on edit" or "Manual save" concept, not both.

Application version

3.2.7

Browser version

Firefox 127.0.1

Logs

No response

Anything else?

No response

@akvlad akvlad added the bug Something isn't working label Jun 26, 2024
jacovinus added a commit to gigapipehq/qryn-view that referenced this issue Jul 22, 2024
Update dev branch with last metrico repo changes
Refs: 

- [metrico#455](metrico#455)
- [metrico#456](metrico#456)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working in review
Projects
None yet
Development

No branches or pull requests

2 participants