Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rose ana test: remove dependency on pcregrep #2235

Merged
merged 1 commit into from
Sep 24, 2018
Merged

rose ana test: remove dependency on pcregrep #2235

merged 1 commit into from
Sep 24, 2018

Conversation

matthewrmshin
Copy link
Member

Replicate functionality with a small Python script.

(Background. My new desktop environment does not have pcregrep installed by default.)

@matthewrmshin
rose ana test: remove dependency on pcregrep
b108056 
Replicate functionality with a small Python script.
@matthewrmshin matthewrmshin added this to the next-release milestone Sep 24, 2018
@matthewrmshin matthewrmshin self-assigned this Sep 24, 2018
@oliver-sanders
Copy link
Member

Test failure in the documentation unrelated.

@oliver-sanders oliver-sanders mentioned this pull request Sep 24, 2018
Closed
oliver-sanders
oliver-sanders approved these changes Sep 24, 2018
View reviewed changes
Copy link
Member

@oliver-sanders oliver-sanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange to see Python used as a standin for Perl for regex functionality!

sadielbartholomew
sadielbartholomew approved these changes Sep 24, 2018
View reviewed changes
Copy link
Contributor

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sensible change. pcregrep recreated (& variables quoted) with no change in behaviour.

@sadielbartholomew sadielbartholomew merged commit 6cbac80 into metomi:master Sep 24, 2018
@matthewrmshin matthewrmshin deleted the rose-ana-test-issue branch September 25, 2018 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliver-sanders oliver-sanders oliver-sanders approved these changes

@sadielbartholomew sadielbartholomew sadielbartholomew approved these changes

Assignees

@matthewrmshin matthewrmshin

Labels
None yet
Projects
None yet
Milestone
2018.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@matthewrmshin @oliver-sanders @sadielbartholomew