Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid HTML Being Generated #95

Closed
RehanSaeed opened this issue May 18, 2020 · 1 comment
Closed

Invalid HTML Being Generated #95

RehanSaeed opened this issue May 18, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@RehanSaeed
Copy link

RehanSaeed commented May 18, 2020 •
edited
Loading

Environment

  • Vssue Version: 1.4.4
  • Platform: GitHub
  • OS: Windows 10
  • Browser: Chrome 81.0.4044.138

Describe the bug

HTML Validator shows that Vssue is generating invalid HTML:

image

The avatar images should have an alt tag which is the username of the user making the comment:
image

Steps To Reproduce

Add some comments
@meteorlxy meteorlxy added the bug Something isn't working label May 19, 2020
@meteorlxy
Copy link
Owner

  1. TransitionGroup default to use span tag ref.

  2. Add alt attr

Thanks a lot.

meteorlxy added a commit that referenced this issue May 19, 2020
@meteorlxy
fix(vssue): add alt for use avatar (close #95)
f5b721c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RehanSaeed @meteorlxy