Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added default params toFile, toStdout in constructor #232

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Added default params toFile, toStdout in constructor #232

merged 1 commit into from
Oct 17, 2023

Conversation

RohovAlex
Copy link
Contributor

@RohovAlex RohovAlex commented Oct 12, 2023 •
edited by tshemsedinov
Loading

  • tests and linter show no problems (npm t)
  • tests are added/updated for bug fixes and new features
  • code is properly formatted (npm run fmt)
  • description of changes is added in CHANGELOG.md
  • update .d.ts typings

@RohovAlex
Copy link
Contributor Author

@tshemsedinov please review.

@tshemsedinov tshemsedinov merged commit 3bc8a52 into metarhia:master Oct 17, 2023
6 of 7 checks passed
@tshemsedinov tshemsedinov changed the title added default params toFile, toStdout in constructor Added default params toFile, toStdout in constructor Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tshemsedinov tshemsedinov tshemsedinov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RohovAlex @tshemsedinov