Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linear_solve): matrix inversion linear solver with neumann series approximation #98

Merged

Conversation

Benjamin-eecs
Copy link
Member

@Benjamin-eecs Benjamin-eecs commented Oct 9, 2022

Description

matrix inversion linear solver with neumann series approximation

Types of changes

  • New feature (non-breaking change which adds core functionality)
  • Documentation (update in the documentation)
  • Example (update in the folder of example)

Checklist

  • I have read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format (required)
  • I have checked the code using make lint (required)
  • I have ensured make test pass. (required)

@Benjamin-eecs Benjamin-eecs changed the title feat: matrix inversion linear solver with neumann series approximation feat(implicit_diff): matrix inversion linear solver with neumann series approximation Oct 9, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2022

Codecov Report

Base: 65.19% // Head: 64.87% // Decreases project coverage by -0.32% ⚠️

Coverage data is based on head (2bd55ba) compared to base (23253b1).
Patch coverage: 63.90% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #98      +/-   ##
==========================================
- Coverage   65.19%   64.87%   -0.33%     
==========================================
  Files          62       65       +3     
  Lines        2655     2787     +132     
==========================================
+ Hits         1731     1808      +77     
- Misses        924      979      +55     
Flag Coverage Δ
unittests 64.87% <63.90%> (-0.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
torchopt/linalg/ns.py 41.81% <41.81%> (ø)
torchopt/linalg/utils.py 52.17% <52.17%> (ø)
torchopt/pytree.py 71.01% <73.46%> (+1.78%) ⬆️
torchopt/linear_solve/inv.py 82.14% <82.14%> (ø)
torchopt/linalg/__init__.py 100.00% <100.00%> (ø)
torchopt/linalg/cg.py 98.14% <100.00%> (+6.36%) ⬆️
torchopt/linear_solve/__init__.py 100.00% <100.00%> (ø)
torchopt/linear_solve/utils.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Benjamin-eecs Benjamin-eecs self-assigned this Oct 10, 2022
@XuehaiPan XuehaiPan force-pushed the feature/neumann_series_approx branch 2 times, most recently from 180f62f to f43d903 Compare October 13, 2022 12:27
@Benjamin-eecs Benjamin-eecs added this to the 0.7.0 milestone Nov 3, 2022
@XuehaiPan XuehaiPan force-pushed the feature/neumann_series_approx branch 2 times, most recently from fb8ec59 to ec0e602 Compare November 3, 2022 13:54
…s approximation

Co-authored-by: Benjamin-eecs <benjaminliu.eecs@gmail.com>
@XuehaiPan XuehaiPan force-pushed the feature/neumann_series_approx branch from ec0e602 to d158462 Compare November 3, 2022 13:57
@XuehaiPan XuehaiPan added enhancement New feature or request feature New feature labels Nov 3, 2022
@Benjamin-eecs Benjamin-eecs requested review from XuehaiPan and removed request for XuehaiPan, waterhorse1 and JieRen98 November 7, 2022 14:21
@XuehaiPan XuehaiPan force-pushed the feature/neumann_series_approx branch from 42809e3 to 8865eb6 Compare November 8, 2022 11:53
XuehaiPan
XuehaiPan previously approved these changes Nov 8, 2022
XuehaiPan
XuehaiPan previously approved these changes Nov 9, 2022
@XuehaiPan XuehaiPan changed the title feat(implicit_diff): matrix inversion linear solver with neumann series approximation feat(linear_solve): matrix inversion linear solver with neumann series approximation Nov 9, 2022
@Benjamin-eecs Benjamin-eecs merged commit 0185f2e into metaopt:main Nov 9, 2022
XuehaiPan pushed a commit to XuehaiPan/torchopt that referenced this pull request Nov 9, 2022
…s approximation (metaopt#98)

* feat(linear_solve): matrix inversion linear solver with neumann series approximation
Co-authored-by: Xuehai Pan <XuehaiPan@pku.edu.cn>
@Benjamin-eecs Benjamin-eecs deleted the feature/neumann_series_approx branch November 9, 2022 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants