Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(examples): align results of distributed examples #95

Merged
merged 10 commits into from
Oct 8, 2022

Conversation

XuehaiPan
Copy link
Member

@XuehaiPan XuehaiPan commented Oct 7, 2022

Description

Describe your changes in detail.

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213

  • I have raised an issue to propose this change (required for new features and bug fixes)

Related issue:

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of example)

Implemented Tasks

  • Subtask 1
  • Subtask 2
  • Subtask 3

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format (required)
  • I have checked the code using make lint (required)
  • I have ensured make test pass. (required)

@XuehaiPan XuehaiPan self-assigned this Oct 8, 2022
@XuehaiPan XuehaiPan added bug Something isn't working upstream Something upstream related pytorch Something PyTorch related example / tutorial Something related to examples or tutorials labels Oct 8, 2022
@XuehaiPan XuehaiPan added this to the 0.6.0 milestone Oct 8, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2022

Codecov Report

Base: 66.59% // Head: 65.58% // Decreases project coverage by -1.01% ⚠️

Coverage data is based on head (f41abae) compared to base (a6aba36).
Patch coverage: 29.07% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #95      +/-   ##
==========================================
- Coverage   66.59%   65.58%   -1.02%     
==========================================
  Files          37       37              
  Lines        1853     1906      +53     
==========================================
+ Hits         1234     1250      +16     
- Misses        619      656      +37     
Flag Coverage Δ
unittests 65.58% <29.07%> (-1.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
torchopt/distributed/api.py 25.87% <0.00%> (-1.95%) ⬇️
torchopt/distributed/autograd.py 30.61% <0.00%> (ø)
torchopt/utils.py 27.27% <24.56%> (+3.49%) ⬆️
torchopt/optim/base.py 84.90% <75.00%> (-0.28%) ⬇️
torchopt/optim/meta/base.py 62.50% <100.00%> (ø)
torchopt/transform.py 81.07% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@XuehaiPan XuehaiPan force-pushed the maml-example branch 2 times, most recently from f41abae to 2009506 Compare October 8, 2022 09:23
@XuehaiPan XuehaiPan changed the title fix(example): align results of distributed examples fix(examples): align results of distributed examples Oct 8, 2022
@XuehaiPan XuehaiPan merged commit 87f1af5 into metaopt:main Oct 8, 2022
@XuehaiPan XuehaiPan deleted the maml-example branch October 8, 2022 09:43
@XuehaiPan XuehaiPan added the distributed Something related to distributed training label Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working distributed Something related to distributed training example / tutorial Something related to examples or tutorials pytorch Something PyTorch related upstream Something upstream related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants