Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adagrad optimizer support #80

Merged
merged 54 commits into from
Mar 22, 2023

Conversation

Benjamin-eecs
Copy link
Member

@Benjamin-eecs Benjamin-eecs commented Sep 17, 2022

Description

Adagrad optimizer support.

Roadmap

  • low-level alias
  • high-level Optimizer
  • high-level MetaOptimizer
  • low-level test
  • high-level Optimizer test
  • api docs
  • CHANGELOG

@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2022

Codecov Report

Patch coverage: 96.09% and project coverage change: +0.32 🎉

Comparison is base (6223010) 93.05% compared to head (c188839) 93.37%.

❗ Current head c188839 differs from pull request most recent head fbb68f8. Consider uploading reports for the commit fbb68f8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
+ Coverage   93.05%   93.37%   +0.32%     
==========================================
  Files          66       71       +5     
  Lines        2574     2684     +110     
==========================================
+ Hits         2395     2506     +111     
+ Misses        179      178       -1     
Flag Coverage Δ
unittests 93.37% <96.09%> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
torchopt/alias/adam.py 100.00% <ø> (ø)
torchopt/alias/adamw.py 100.00% <ø> (ø)
torchopt/alias/sgd.py 100.00% <ø> (ø)
torchopt/optim/adam.py 100.00% <ø> (ø)
torchopt/optim/adamw.py 100.00% <ø> (ø)
torchopt/optim/func/base.py 88.46% <ø> (ø)
torchopt/optim/meta/adamw.py 90.91% <ø> (ø)
torchopt/schedule/polynomial.py 100.00% <ø> (+19.05%) ⬆️
torchopt/transform/scale_by_adam.py 100.00% <ø> (ø)
torchopt/transform/scale_by_rms.py 100.00% <ø> (ø)
... and 13 more

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Benjamin-eecs Benjamin-eecs self-assigned this Oct 13, 2022
@XuehaiPan XuehaiPan force-pushed the feature/adagrad branch 2 times, most recently from 1e6fb9e to d3310c7 Compare October 13, 2022 11:53
@XuehaiPan XuehaiPan added enhancement New feature or request feature New feature labels Nov 3, 2022
Co-authored-by: Benjamin-eecs <benjaminliu.eecs@gmail.com>
@Benjamin-eecs Benjamin-eecs added this to the 0.8.0 milestone Feb 15, 2023
@XuehaiPan XuehaiPan force-pushed the feature/adagrad branch 3 times, most recently from 13fdeca to a701283 Compare March 22, 2023 08:31
@XuehaiPan XuehaiPan force-pushed the feature/adagrad branch 2 times, most recently from d5b3418 to fc04c06 Compare March 22, 2023 08:56
XuehaiPan
XuehaiPan previously approved these changes Mar 22, 2023
@Benjamin-eecs Benjamin-eecs merged commit 4701569 into metaopt:main Mar 22, 2023
@Benjamin-eecs Benjamin-eecs deleted the feature/adagrad branch March 22, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants