Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implicit differentiation integration #41

Merged
merged 62 commits into from
Sep 8, 2022
Merged

feat: implicit differentiation integration #41

merged 62 commits into from
Sep 8, 2022

Conversation

Benjamin-eecs
Copy link
Member

#13

@Benjamin-eecs Benjamin-eecs linked an issue Jul 25, 2022 that may be closed by this pull request
[Feature Request] Implicit gradient support #13
Closed
7 tasks
@Benjamin-eecs Benjamin-eecs added the enhancement New feature or request label Jul 25, 2022
@Benjamin-eecs Benjamin-eecs added this to the 0.5.0 milestone Jul 25, 2022
@XuehaiPan XuehaiPan added the feature New feature label Jul 26, 2022
XuehaiPan
XuehaiPan requested changes Aug 10, 2022
View reviewed changes
Copy link
Member

@XuehaiPan XuehaiPan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fetch the latest upstream, and rebase your commits. Besides, don't forget to setup the pre-commit hooks.

@JieRen98
style(implicit): clean codes
1f2bac0
@JieRen98
fix(implicit): fix 0-d tensor
362fbb4
@JieRen98
fix(implicit): fix 0-d tensor
aa29460
@JieRen98
fix(implicit): fix res is tensor
309b25d
@JieRen98
fix(implicit): make aux does not require grad
ddaa619
@JieRen98
Merge branch 'merge-remote' into dev-implicit
5af9181 
# Conflicts:
#	TorchOpt/_src/Optimizer.py
#	TorchOpt/_src/alias.py
#	TorchOpt/_src/transform.py
#	TorchOpt/_src/utils.py
#	third_party/pybind11
#	torchopt/_src/clip.py
#	torchopt/_src/hook.py
#	torchopt/_src/implicit_diff.py
#	torchopt/_src/linalg.py
#	torchopt/_src/linear_solve.py
#	torchopt/_src/schedule.py
#	torchopt/_src/typing.py
#	torchopt/_src/update.py
@JieRen98
fix(implicit): import implicit functions
7d4b1a0
XuehaiPan
XuehaiPan reviewed Sep 7, 2022
View reviewed changes
torchopt/_src/linalg.py Outdated Show resolved Hide resolved
XuehaiPan
XuehaiPan previously approved these changes Sep 7, 2022
View reviewed changes
@Benjamin-eecs Benjamin-eecs changed the title Implicit differentiation integration feat: implicit differentiation integration Sep 7, 2022
waterhorse1
waterhorse1 previously approved these changes Sep 7, 2022
View reviewed changes
@Benjamin-eecs Benjamin-eecs requested review from JieRen98 and XuehaiPan and removed request for XuehaiPan September 7, 2022 16:53
XuehaiPan
XuehaiPan previously approved these changes Sep 8, 2022
View reviewed changes
@XuehaiPan XuehaiPan merged commit da00100 into metaopt:main Sep 8, 2022
@XuehaiPan XuehaiPan deleted the dev-implicit branch September 8, 2022 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuehaiPan XuehaiPan XuehaiPan approved these changes

@waterhorse1 waterhorse1 waterhorse1 left review comments

@JieRen98 JieRen98 Awaiting requested review from JieRen98

Assignees

@waterhorse1 waterhorse1

@Benjamin-eecs Benjamin-eecs

@JieRen98 JieRen98

Labels
enhancement New feature or request feature New feature functorch Something functorch related
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.

[Feature Request] Implicit gradient support
5 participants
@Benjamin-eecs @codecov-commenter @XuehaiPan @waterhorse1 @JieRen98