Do not sort targets from mirrord ls based on string values, instead let the iterator chain handle it. #2732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et the iterator chain handle it.
Razz4780
approved these changes
Sep 5, 2024
|
Note - targets are still sorted in the plugin here |
|
Can we switch the order so deployments will always be first? |
Maybe deployments -> rollouts -> whatever? |
sure |
|
I don't have any rollout, but cli now presents it like this: And the extension:
|
Razz4780
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove a string sort that we had in the targets, when running
mirrord ls. We have a neat chain of iterators that sorts the targets by type, starting withpods, which is nicer than alphabetical ordering.