Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Document backporting rules for Go lang minor versions for images #1770

Merged
merged 1 commit into from
Jun 20, 2024
Merged

📖 Document backporting rules for Go lang minor versions for images #1770

merged 1 commit into from
Jun 20, 2024

Conversation

kashifest
Copy link
Member

This PR also rewrites the Backporting section a bit and puts on clear identifiers for backporting rules.
Signed-off-by: Kashif Khan kashif.khan@est.tech

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 17, 2024
@kashifest
Copy link
Member Author

/cc @tuminoid

tuminoid
tuminoid reviewed Jun 17, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally I like the edit, thanks!

CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@kashifest kashifest force-pushed the kashif/document-golang-bump branch from 4f70554 to 35b073e Compare June 17, 2024 11:49
@kashifest
Document backporting rules for Go lang minor versions for images
b3636a9 
This PR also rewrites the Backporting section a bit and puts on clear identifiers for backporting rules.
Signed-off-by: Kashif Khan <kashif.khan@est.tech>
@kashifest kashifest force-pushed the kashif/document-golang-bump branch from 35b073e to b3636a9 Compare June 17, 2024 12:07
tuminoid
tuminoid reviewed Jun 17, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
tuminoid
tuminoid reviewed Jun 17, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

I'm cool with this wording now, thanks for updating it!

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 17, 2024
@kashifest
Copy link
Member Author

/override metal3-centos-e2e-integration-test-main
/override metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot
Copy link
Contributor

@kashifest: Overrode contexts on behalf of kashifest: metal3-centos-e2e-integration-test-main, metal3-ubuntu-e2e-integration-test-main

In response to this:

/override metal3-centos-e2e-integration-test-main
/override metal3-ubuntu-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kashifest
Copy link
Member Author

/cc @dtantsur @adilGhaffarDev @Sunnatillo @mboukhalfa

Sunnatillo
Sunnatillo approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Sunnatillo, tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Sunnatillo,tuminoid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kashifest
Copy link
Member Author

/approve

it already has approve label, needs lgtm

Sunnatillo
Sunnatillo reviewed Jun 20, 2024
View reviewed changes
Copy link
Member

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 20, 2024
@metal3-io-bot metal3-io-bot merged commit 82210af into metal3-io:main Jun 20, 2024
13 checks passed
@metal3-io-bot metal3-io-bot deleted the kashif/document-golang-bump branch June 20, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

@Sunnatillo Sunnatillo Sunnatillo approved these changes

@adilGhaffarDev adilGhaffarDev Awaiting requested review from adilGhaffarDev

@dtantsur dtantsur Awaiting requested review from dtantsur

@mboukhalfa mboukhalfa Awaiting requested review from mboukhalfa

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kashifest @metal3-io-bot @tuminoid @Sunnatillo