Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fixing bmo version for clusterctl tests #1596

Merged
merged 1 commit into from
Jul 5, 2024
Merged

🐛 Fixing bmo version for clusterctl tests #1596

merged 1 commit into from
Jul 5, 2024

Conversation

adilGhaffarDev
Copy link
Member

What this PR does / why we need it:
clustetctl tests were using the wrong version of bmo and ironic before the upgrade. This PR fixes that by checking out bmo repo to right supported branch before installing bmo and ironic.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 15, 2024
smoshiur1237
smoshiur1237 reviewed Apr 15, 2024
View reviewed changes
test/e2e/common.go Outdated Show resolved Hide resolved
@adilGhaffarDev adilGhaffarDev force-pushed the fix-clusterctl-bmo-version/adil branch 2 times, most recently from d72b357 to 3e45648 Compare April 15, 2024 10:34
@adilGhaffarDev
Copy link
Member Author

metal3-e2e-clusterctl-upgrade-test-main

@adilGhaffarDev
Copy link
Member Author

/test metal3-e2e-clusterctl-upgrade-test-main

lentzi90
lentzi90 reviewed Apr 16, 2024
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2024
@adilGhaffarDev adilGhaffarDev force-pushed the fix-clusterctl-bmo-version/adil branch from 3e45648 to 98a67fb Compare April 16, 2024 06:22
@metal3-io-bot metal3-io-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 16, 2024
@adilGhaffarDev adilGhaffarDev force-pushed the fix-clusterctl-bmo-version/adil branch 2 times, most recently from d95a6bd to 1ab98e6 Compare April 16, 2024 06:39
@adilGhaffarDev
Copy link
Member Author

/test metal3-e2e-clusterctl-upgrade-test-main

@adilGhaffarDev adilGhaffarDev changed the title 🐛 Fixing bmo version for clusterctl tests [wip]🐛 Fixing bmo version for clusterctl tests Apr 18, 2024
@metal3-io-bot metal3-io-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 18, 2024
@adilGhaffarDev
Copy link
Member Author

/hold

@metal3-io-bot metal3-io-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 18, 2024
@adilGhaffarDev adilGhaffarDev force-pushed the fix-clusterctl-bmo-version/adil branch from 1ab98e6 to fec0452 Compare April 23, 2024 09:21
@metal3-io-bot metal3-io-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 23, 2024
@adilGhaffarDev adilGhaffarDev force-pushed the fix-clusterctl-bmo-version/adil branch from fec0452 to 6cdce9d Compare April 23, 2024 09:24
@metal3-io-bot metal3-io-bot added needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 23, 2024
@adilGhaffarDev adilGhaffarDev force-pushed the fix-clusterctl-bmo-version/adil branch from 0823e1d to 33308f4 Compare April 25, 2024 13:26
@metal3-io-bot metal3-io-bot removed the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Apr 25, 2024
@adilGhaffarDev adilGhaffarDev force-pushed the fix-clusterctl-bmo-version/adil branch from 33308f4 to 3016d87 Compare April 25, 2024 13:37
@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 27, 2024
@adilGhaffarDev
Copy link
Member Author

@mboukhalfa , @kashifest please review.

@adilGhaffarDev adilGhaffarDev force-pushed the fix-clusterctl-bmo-version/adil branch from cd7dec8 to 996b510 Compare June 27, 2024 07:04
@adilGhaffarDev
Copy link
Member Author

/test metal3-e2e-clusterctl-upgrade-test-main

@adilGhaffarDev adilGhaffarDev force-pushed the fix-clusterctl-bmo-version/adil branch from 996b510 to 03be7f1 Compare June 28, 2024 09:11
@adilGhaffarDev
Copy link
Member Author

/test metal3-e2e-clusterctl-upgrade-test-main

@Rozzii Rozzii added this to the 1.8.0 milestone Jun 28, 2024
@adilGhaffarDev
Copy link
Member Author

/test metal3-centos-e2e-integration-test-main

@adilGhaffarDev
Copy link
Member Author

/test metal3-ubuntu-e2e-integration-test-main

@adilGhaffarDev
Copy link
Member Author

/test metal3-centos-e2e-integration-test-main

tuminoid
tuminoid reviewed Jul 2, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits.

scripts/ci-e2e.sh Outdated Show resolved Hide resolved
scripts/ci-e2e.sh Outdated Show resolved Hide resolved
scripts/ci-e2e.sh Outdated Show resolved Hide resolved
scripts/ci-e2e.sh Outdated Show resolved Hide resolved
scripts/ci-e2e.sh Outdated Show resolved Hide resolved
test/e2e/data/ironic-deployment/overlays/release-24.1/kustomization.yaml Outdated Show resolved Hide resolved
test/e2e/data/ironic-deployment/overlays/release-24.1/kustomization.yaml Outdated Show resolved Hide resolved
test/e2e/data/ironic-deployment/overlays/release-latest/ironic_bmo_configmap.env Outdated Show resolved Hide resolved
test/e2e/data/ironic-deployment/overlays/release-latest/kustomization.yaml Outdated Show resolved Hide resolved
test/e2e/data/ironic-deployment/overlays/release-latest/kustomization.yaml Outdated Show resolved Hide resolved
@adilGhaffarDev adilGhaffarDev force-pushed the fix-clusterctl-bmo-version/adil branch from 03be7f1 to 207f77f Compare July 4, 2024 06:03
@adilGhaffarDev
Copy link
Member Author

@tuminoid fixed the improvements. please check.

tuminoid
tuminoid reviewed Jul 4, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two nits still to go.

scripts/ci-e2e.sh Outdated Show resolved Hide resolved
scripts/ci-e2e.sh Show resolved Hide resolved
@adilGhaffarDev adilGhaffarDev force-pushed the fix-clusterctl-bmo-version/adil branch from 207f77f to 66a1ef2 Compare July 4, 2024 11:27
@adilGhaffarDev
Fixing bmo version for clusterctl tests
1620771 
Signed-off-by: adil ghaffar <muhammad.adil.ghaffar@est.tech>
@adilGhaffarDev adilGhaffarDev force-pushed the fix-clusterctl-bmo-version/adil branch from 66a1ef2 to 1620771 Compare July 4, 2024 11:28
tuminoid
tuminoid reviewed Jul 4, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 4, 2024
@adilGhaffarDev
Copy link
Member Author

/test metal3-e2e-clusterctl-upgrade-test-main

@tuminoid
Copy link
Member

tuminoid commented Jul 4, 2024

/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main
/hold

clusterctl tests to be run on the final code, held until it passes

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 4, 2024
@metal3-io-bot
Copy link
Contributor

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-centos-e2e-integration-test-main, metal3-ubuntu-e2e-integration-test-main

In response to this:

/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main
/hold

clusterctl tests to be run on the final code, held until it passes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tuminoid
Copy link
Member

tuminoid commented Jul 5, 2024

/unhold

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 5, 2024
@metal3-io-bot metal3-io-bot merged commit e435bd8 into metal3-io:main Jul 5, 2024
18 checks passed
@metal3-io-bot metal3-io-bot deleted the fix-clusterctl-bmo-version/adil branch July 5, 2024 05:35
This was referenced Jul 5, 2024
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

@lentzi90 lentzi90 lentzi90 left review comments

@smoshiur1237 smoshiur1237 smoshiur1237 left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
Metal3 - Roadmap
Status: Done / Closed
Milestone
CAPM3 - 1.8.0
Development

Successfully merging this pull request may close these issues.
7 participants
@adilGhaffarDev @metal3-io-bot @mboukhalfa @tuminoid @lentzi90 @smoshiur1237 @Rozzii