Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 try fix GH workflow for image building #1488

Merged
merged 1 commit into from
Mar 1, 2024
Merged

🌱 try fix GH workflow for image building #1488

merged 1 commit into from
Mar 1, 2024

Conversation

tuminoid
Copy link
Member

@tuminoid tuminoid commented Mar 1, 2024

Image build action is not triggering for anything but main, which is the only trigger not having * in it. So, let's try removing the quotes as any of the GH examples do not use quotes unless it is mandatory (ie. leading *, or []).

@tuminoid
try fix GH workflow for build images
98ae522 
Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 1, 2024
@tuminoid
Copy link
Member Author

tuminoid commented Mar 1, 2024

/override test-centos-e2e-integration-main test-ubuntu-integration-main

@metal3-io-bot
Copy link
Contributor

@tuminoid: Overrode contexts on behalf of tuminoid: test-centos-e2e-integration-main, test-ubuntu-integration-main

In response to this:

/override test-centos-e2e-integration-main test-ubuntu-integration-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mboukhalfa
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboukhalfa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2024
smoshiur1237
smoshiur1237 reviewed Mar 1, 2024
View reviewed changes
Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2024
@tuminoid tuminoid changed the title 🌱 try fix GH workflow for build images 🌱 try fix GH workflow for image building Mar 1, 2024
@metal3-io-bot metal3-io-bot merged commit 971f963 into metal3-io:main Mar 1, 2024
20 checks passed
@metal3-io-bot metal3-io-bot deleted the tuomo/fix-build-image-workflow branch March 1, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoshiur1237 smoshiur1237 smoshiur1237 left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tuminoid @metal3-io-bot @mboukhalfa @smoshiur1237