🌱 Use k8s apimachinery scheme builder instead of controller-runtime scheme builder

[kashifest]

This is recommend for the CAPI providers as mentioned the v1.5 to v1.6 migration guide: https://cluster-api.sigs.k8s.io/developer/providers/migrations/v1.5-to-v1.6#suggested-changes-for-providers.

The original issue was discussed in kubernetes-sigs/cluster-api#9011. The issue is using controller-runtime based scheme builder causes a lot of unnecessary dependancies added in go modules. Compared to that apimachinery was chosen as a better alternative.

[kashifest]

/test-ubuntu-integration-main
/test-centos-e2e-integration-main

[kashifest]

/keep-test-ubuntu-integration-main

[kashifest]

/keep-test-ubuntu-integration-main

[kashifest]

/test-ubuntu-integration-main

[kashifest]

/override keep-test-ubuntu-integration-main

[metal3-io-bot]

@kashifest: Overrode contexts on behalf of kashifest: keep-test-ubuntu-integration-main

In response to this:

/override keep-test-ubuntu-integration-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[lentzi90]

/approve

[metal3-io-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [lentzi90]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[lentzi90]

I see this did not affect the go modules. Should we update/clean them also, or do we still depend on the controller-runtime scheme builder is some place?

[smoshiur1237]

I see this did not affect the go modules. Should we update/clean them also, or do we still depend on the controller-runtime scheme builder is some place?

As it is not affecting the go modules and test with gomod is passing. We can take this in.

[smoshiur1237]

/lgtm

[kashifest]

I see this did not affect the go modules. Should we update/clean them also, or do we still depend on the controller-runtime scheme builder is some place?

Yes, I wondered the same. My understanding is we didnt directly imported any module named sigs.k8s.io/controller-runtime/pkg/scheme which we removed here, rather we use sigs.k8s.io/controller-runtime module and that is something which is still used so no change in go module.