Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Add github action to trigger container image build #1338

Merged
merged 1 commit into from
Jan 15, 2024
Merged

🌱 Add github action to trigger container image build #1338

merged 1 commit into from
Jan 15, 2024

Conversation

mquhuy
Copy link
Member

@mquhuy mquhuy commented Nov 22, 2023

This PR adds an action to trigger capm3 container build whenever a PR is merged in this repo.

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 22, 2023
kashifest
kashifest reviewed Nov 24, 2023
View reviewed changes
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we hold this and others and test if the IPAM PR metal3-io/ip-address-manager#386 is working as expected first?

@mquhuy mquhuy force-pushed the mquhuy/add-container-image-build-action branch from 1f83c27 to 27557b9 Compare November 24, 2023 10:08
@mquhuy
Copy link
Member Author

mquhuy commented Nov 24, 2023

can we hold this and others and test if the IPAM PR metal3-io/ip-address-manager#386 is working as expected first?

Sure. For now we can test out by merging one of them

@mquhuy mquhuy force-pushed the mquhuy/add-container-image-build-action branch 2 times, most recently from af58357 to e33c001 Compare November 24, 2023 13:44
@mquhuy
Copy link
Member Author

mquhuy commented Nov 27, 2023

/hold

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 27, 2023
@mquhuy mquhuy force-pushed the mquhuy/add-container-image-build-action branch from e33c001 to 0906e95 Compare December 1, 2023 10:16
@metal3-io-bot metal3-io-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 1, 2023
@mquhuy mquhuy force-pushed the mquhuy/add-container-image-build-action branch from 0906e95 to b65b75e Compare December 1, 2023 10:56
tuminoid
tuminoid requested changes Dec 1, 2023
View reviewed changes
.github/workflows/build-images-action.yml Show resolved Hide resolved
.github/workflows/build-images-action.yml Outdated
job_name: "metal3_cluster-api-provider-metal3_container_image_building"
job_params: |
{
"BUILD_CONTAINER_IMAGE_NAME": "baremetal-operator",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is CAPM3 repo.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops

@mquhuy mquhuy force-pushed the mquhuy/add-container-image-build-action branch 2 times, most recently from b80d7c9 to c261c36 Compare December 1, 2023 12:02
smoshiur1237
smoshiur1237 reviewed Dec 1, 2023
View reviewed changes
Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2023
tuminoid
tuminoid reviewed Dec 1, 2023
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should work.
/lgtm

As discussed off-line, let's start slowly with some lower traffic image next week, and gradually move to this way of building.

@mquhuy mquhuy force-pushed the mquhuy/add-container-image-build-action branch from c261c36 to 4c00577 Compare December 7, 2023 07:59
@metal3-io-bot metal3-io-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 7, 2023
tuminoid
tuminoid reviewed Jan 10, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2024
@tuminoid
Copy link
Member

/override test-centos-e2e-integration-main test-ubuntu-integration-main

@metal3-io-bot
Copy link
Contributor

@tuminoid: Overrode contexts on behalf of tuminoid: test-centos-e2e-integration-main, test-ubuntu-integration-main

In response to this:

/override test-centos-e2e-integration-main test-ubuntu-integration-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tuminoid
Copy link
Member

/assign @kashifest

@kashifest
Copy link
Member

/approve

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2024
@kashifest kashifest changed the title ✨ Add github action to trigger container image build 🌱 Add github action to trigger container image build Jan 15, 2024
@tuminoid
Copy link
Member

/unhold

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 15, 2024
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest, tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot merged commit 7707265 into metal3-io:main Jan 15, 2024
19 checks passed
@metal3-io-bot metal3-io-bot deleted the mquhuy/add-container-image-build-action branch January 15, 2024 09:03
@tuminoid
Copy link
Member

I've disabled the builld trigger in Quay for CAPM3. All builds should flow thru this workflow + Jenkins now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kashifest kashifest kashifest left review comments

@smoshiur1237 smoshiur1237 smoshiur1237 left review comments

@tuminoid tuminoid tuminoid approved these changes

Assignees

@kashifest kashifest

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mquhuy @tuminoid @metal3-io-bot @kashifest @smoshiur1237